Skip to content

Conversation

@pkuczynski
Copy link
Member

Fixes #198

@pkuczynski
Copy link
Member Author

@pyromaniac I thought your last PR would fix this issue (by moving to instance variables). Do you have any idea why its still not the case?

@pkuczynski
Copy link
Member Author

@supremebeing7 maybe you want to have a quick look?

@supremebeing7
Copy link
Contributor

Nothing jumps out to me, I'd have to spend more time diving in and I don't have that time available right now. I will check it out when I do, if it's still an issue by then.

@pkuczynski pkuczynski modified the milestones: 2.1.0, 2.2.0, 2.2.1, 2.3.0 Jan 3, 2020
@pkuczynski
Copy link
Member Author

@cjlarose do you wanna look into this one too? It's a pretty poor setup we have, that test needs to be executed in a certain order. Would be good to clean them up, make them independent, and maybe even limit the number of fixtures we have to use...

@cjlarose
Copy link
Member

cjlarose commented Dec 9, 2020

Yeah, I can take a look. It'd be good to get 'em running in random order and to prevent new tests from getting in that depend on the execution order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Specs rely on test order

4 participants