Replace remote search selects with static dropdowns on story admin form#1264
Merged
Replace remote search selects with static dropdowns on story admin form#1264
Conversation
The remote-select AJAX search for story author and spotlighted facilitator was unreliable. Switch to static <select> dropdowns populated with all users/people, with sensible alphabetical ordering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The form partial now uses @users and @people for static dropdown collections. View specs render the partial directly without the controller, so these instance variables must be assigned in the test setup. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
<select>dropdowns that load all available options upfront for a more dependable experienceHow did you approach the change?
@peopleand@usersinstance variables inStoriesController#set_form_variableswith alphabetical ordering viaArel.sql@usersloads all users with portal access, ordered by person name (nulls last) then email@peopleloads all people ordered by first/last name (case-insensitive)remote-selectStimulus controller inputs with standard SimpleForm collection selectsselect_caret_class,custom_caret_style,select_caret_onchange) consistent with other dropdowns in the formUI Testing Checklist
Anything else to add?
remote-selectStimulus controller for these two fields🤖 Generated with Claude Code