Add test for organization sectors#1269
Merged
maebeale merged 2 commits intorubyforgood:mainfrom Mar 1, 2026
Merged
Conversation
Contributor
Author
maebeale
reviewed
Mar 1, 2026
| @@ -0,0 +1,89 @@ | |||
| require "rails_helper" | |||
|
|
|||
| RSpec.describe "Navbar avatar behavior", type: :system do | |||
Collaborator
There was a problem hiding this comment.
should this be named "Organization sector displays" rather than "Navbar avatar behavior" ?
Contributor
Author
|
@maebeale Fixed the test description to “Organization sector displays” to better reflect what the spec is actually covering. Thanks for catching that! |
maebeale
approved these changes
Mar 1, 2026
Collaborator
maebeale
left a comment
maebeale
left a comment
There was a problem hiding this comment.
Perfecto! Thanks, @diti0-dot !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
This PR adds system tests for sector visibility on the organization show page and populations served page. The tests verify that:
How did you approach the change?
The tests follow the existing logic defined in
organization.rbfor direct and affiliated sectors, and mirror the behavior implemented in the organizations controller.UI Testing Checklist
Anything else to add?
Nothing.
🤖 Generated with Claude Code