This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Fix bug in indentation of "private def" methods #206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug in the plugin's auto-indentation where a method declared as private on the same line as its definition would fail to indent correctly. "private def" was added as a keyword in the regex to keep the regex simple and explicit. Reading the code shows you that "private def" is something for which the editor should increase the indentation level automatically. Fixes rubyide#203
This was referenced Sep 16, 2017
|
Hi, what's about |
|
@juicemia take a look microsoft/vscode#34795 |
Author
|
@faustinoaq so it looks like they fixed it then? Can this PR be closed? |
|
@juicemia I think this PR is still valid because is fixed on |
|
Fixed by #223 |
Collaborator
|
Looks like this was superseded by another PR so I'm going to close it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the plugin's auto-indentation where a method declared
as private on the same line as its definition would fail to indent
correctly.
"private def" was added as a keyword in the regex to keep the regex
simple and explicit. Reading the code shows you that "private def" is
something for which the editor should increase the indentation level
automatically.
Fixes #203
Make sure these boxes are checked before submitting your PR -- thanks in advance!