This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Modify upstream grammar to support optimistic syntax. Resolves #251. #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 3, 2018
The original syntax highlighting was based on an "optimistic" syntax highlighting grammar. This change allows us to continue to use the upstream Atom grammar but will insert the correct grammar scopes to still support the optimistic highlighting
wingrunr21
force-pushed
the
make_grammar_optimistic_again
branch
from
c645211 to
15b9624
Compare
srprkr
approved these changes
Mar 3, 2018
|
Hello, After march update I've noticed odd highlighting and found out in the changelog that there were changes regarding this. So the question is, in this particular example, is method call
Thanks |
Collaborator
Author
|
@roflomglol would you mind moving this to a new issue? I can follow up there |
|
@wingrunr21 Yeah, sure. Sorry, thats probably not a good place to discuss it. :) Here is the issue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original syntax highlighting was based on an "optimistic" syntax highlighting grammar. This change allows us to continue to use the upstream Atom grammar but will insert the correct grammar scopes to still support the optimistic highlighting.
See here for information on what these scopes mean and why.
Note that I could not discover a way to support
constant.other.symbolandconstant.language.symbolat the same time. This means Ruby symbols will be highlighted the same as core language constants (likenil). In reality this is probably ok as most themes with explicit support appear to map the same color to both types.Before:
After:
