Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Conversation

@andrewmcodes
Copy link

@andrewmcodes andrewmcodes commented Sep 18, 2018

After running through the issues and spending a few hours trying to figure out why rubocop, I came to the following conclusions:

Rubocop linting works if the settings are as follows:

	"rubocop": {
		"only": ["SpaceInsideBlockBraces", "LeadingCommentSpace"],
		"lint": false,
		"rails": false
	},

or

	"rubocop": {
		"rails": true
	},

I am opening this PR so that others can give input, as I could not find the core issue on my own. But, it looks like if lint: true is not included in the rubocop settings, linting works as expected. This is consistent the behavior described in #261.

  • [] The build passes
  • TSLint is mostly happy
  • Prettier has been run

@javiervidal
Copy link

javiervidal commented Jan 10, 2019

Yes, lint: true does not work inside rubocop.

@wingrunr21
Copy link
Collaborator

This shouldn't be needed anymore with #405 merged. It should make the RuboCop linting much more resilient.

@wingrunr21 wingrunr21 closed this Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants