Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Conversation

@jamesmosier
Copy link

Building off of #333, I added a settings option detachDebugger which will allow a user to chose to just detach instead of quitting a debugging process. This helps to make sure your Rails server doesn't get shut down whenever you quit the debugger.

If/when this PR is merged, I will update the wiki page to reflect the new option.

  • The build passes
  • TSLint is mostly happy
  • Prettier has been run

@wingrunr21
Copy link
Collaborator

Have you verified that you can re-attach to a detached debugger?

@jamesmosier
Copy link
Author

Ahh I didn't try that. Unfortunately no, it does not. I believe it is plagued by the same issue mentioned in #125

@wingrunr21
Copy link
Collaborator

wingrunr21 commented Oct 20, 2018

I'm still not sure I like this change. Here's what the VSCode docs say on this:

VS Code terminates a debug session with the disconnect request. If the debug target was 'launched' disconnect is expected to terminate the target program (even forcefully if necessary). If the debug target has been 'attached' initially, disconnect should detach it from the target (so that it will continue to run).

So this change goes against their debugger recommendations. In addition, what workflow would one use to either reattach to the process (I do need to fix it via #125 but let's assume for now I have not) or kill the process? Wouldn't starting a new debug session spawn a new Ruby process (or another Rails server)?

@wingrunr21 wingrunr21 mentioned this pull request Oct 20, 2018
2 tasks
@JesseObrien
Copy link

What's the reasoning for this not being worked on still? Because it won't re-attach to the process?

The change seems to be in line with their debugger recommendations, if it attaches to a debugger, then it should detach, not send a quit command. Right now it's killing the rdebug-ide process entirely when you disconnect.

@wingrunr21
Copy link
Collaborator

That's not what this PR does. The debugger (and its behavior) IS being worked on

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants