Allow rails 3.1#139
Closed
tamird wants to merge 1 commit into
Closed
Conversation
Collaborator
There was a problem hiding this comment.
Please make this ~> 3.1, by using >= you're actually allowing any future version of Rails, including a Rails 4, 5 or 6 version.
Collaborator
|
Thanks @tamird :) I've added this to the rails3 branch. |
Author
|
are you sure? don't see it |
Author
|
thanks! would you mind cutting a release with this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So the tests on rails3 don't pass at all (including on 3.2), but the same tests fail on 3.1 and 3.2.
Unfortunately, the latest version of this gem available for 3.1 suffers from https://github.com/radar/paranoia/issue/81. This patch will make fix that issue for rails 3.1 apps.