Skip to content

Mongoid Paranoia Sync#66

Merged
radar merged 11 commits into
rubysherpas:masterfrom
jwg2s:develop
Jul 18, 2013
Merged

Mongoid Paranoia Sync#66
radar merged 11 commits into
rubysherpas:masterfrom
jwg2s:develop

Conversation

@jwg2s
Copy link
Copy Markdown

@jwg2s jwg2s commented Jul 11, 2013

I'm adding some aliases to scopes so that the methods sync with Mongoid Paranoia methods. We're using polygot databases and I think it's nicer to have consistent methods across components tasked with doing the same thing.

Maybe one day I'll combine the two gems to work with ActiveRecord & Mongoid.

Also contains formatting changes. If you use different formatting settings with your IDE I can adjust.

https://github.com/simi/mongoid-paranoia

Comment thread lib/paranoia.rb
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no difference here ;)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, I was just taught to put certain SQL phrases in all caps, just a style thing -- I can undo if you'd like

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pedantic but not that pedantic. Leave it be :)

@radar
Copy link
Copy Markdown
Collaborator

radar commented Jul 16, 2013

Please remove the require for debugger and then this patch is good to go.

@jwg2s
Copy link
Copy Markdown
Author

jwg2s commented Jul 16, 2013

Should be good to go

radar added a commit that referenced this pull request Jul 18, 2013
@radar radar merged commit 63ffba7 into rubysherpas:master Jul 18, 2013
@radar
Copy link
Copy Markdown
Collaborator

radar commented Jul 18, 2013

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants