c8d/daemon: Add remote snapshotters to config #44
Open
c8d/daemon: Add remote snapshotters to config #44
Conversation
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
requies passing context around Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Initial version that doesn't handle any filters Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Without this "docker build" fails with:
Error response from daemon: exporter "image" could not be found
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
The legacy v1 is not supported by the containerd import Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
To make it possible to load emptyfs which is amd64 only Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Move opentelemetry dependencies to direct Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
emptyfs: Use newer image layout
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Fix linting issues
containerd/save: Export only present platform manifests
vendor: re-run hack/vendor.sh
This change fixes multiple things: * pass ctx instead of nil because we need it while computing the layer size * don't return an error if the container is not found during the layer size calculation, if a container is not found it means that it exited * create the container with the image it was created from, the image is used when computing the layer size Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Fix `docker system df`
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Also moved some layerStore related initialization to the non-c8d case because otherwise they get treated as a graphdriver plugins. Co-authored-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Make the snapshotter configurable
The remote snapshotters have to be configured in the `containerd.toml`. Add the proxy plugin configuration to the contained daemon opts. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
containerd-snapshotters-proxy-plugins
branch
from
c31725d to
d930a4a
Compare
Collaborator
Author
|
Rebased |
rumpl
approved these changes
Aug 9, 2022
thaJeztah
reviewed
Aug 10, 2022
Comment on lines
+62
to
+67
| func WithProxyPlugin(name string, plugin config.ProxyPlugin) DaemonOpt { | ||
| return func(r *remote) error { | ||
| r.ProxyPlugins[name] = plugin | ||
| return nil | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
FWIW; we discussed some things around this in the maintainers meeting; we want to stop adding new features to the generated configuration (when running a managed containerd / containerd as child process), and instead allow users to create their own containerd.toml for configuring containerd options.
I started some work on a patch to allow that feature (started to dust it off Yesterday evening)
I realise that this PR is easier (for now), and will get us going for the PoC; but possibly this approach will change in upstream (at least).
Collaborator
Quick heads up; I pushed a PR with that proposal; moby#43946 |
vvoland
force-pushed
the
c8d
branch
2 times, most recently
from
5e88685 to
ac7a31e
Compare
vvoland
force-pushed
the
c8d
branch
2 times, most recently
from
13b2b08 to
ff5b724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires:
This adds the proxy plugin configuration to the generated
containerd.tomlthat is used for the moby's supervised containerd process.So to use the new snapshotters, you just need to make sure they are running on their default socket address and run the engine with the
--containerd-snapshotter.This also adds
--containerd-snapshotter-addrwhich can be used to override the default snapshotter plugin socket address.- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)