Skip to content

let buildx know we support containerd snapshotter #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rumpl merged 1 commit into from
Aug 10, 2022
Merged

let buildx know we support containerd snapshotter #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion builder/builder-next/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ func newSnapshotterController(rt http.RoundTripper, opt Opt) (*mobycontrol.Contr
snapshotter := ctd.DefaultSnapshotter
Copy link
Copy Markdown
Collaborator

@vvoland vvoland Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please rebase on #40 for this to be configured instead of hardcoded containerd snapshotter


wo, err := containerd.NewWorkerOpt(opt.Root, opt.ContainerdAddress, snapshotter, opt.ContainerdNamespace,
opt.Rootless, map[string]string{}, dns, nc, opt.ApparmorProfile, nil, "", ctd.WithTimeout(60*time.Second))
opt.Rootless, map[string]string{
worker.LabelSnapshotter: snapshotter,
}, dns, nc, opt.ApparmorProfile, nil, "", ctd.WithTimeout(60*time.Second))
if err != nil {
return nil, err
}
Expand Down