patch dev environment for working with containerd-snapshotter#59
Draft
tonistiigi wants to merge 58 commits intorumpl:c8dfrom
Draft
patch dev environment for working with containerd-snapshotter#59tonistiigi wants to merge 58 commits intorumpl:c8dfrom
tonistiigi wants to merge 58 commits intorumpl:c8dfrom
Conversation
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
requies passing context around Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Initial version that doesn't handle any filters Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Without this "docker build" fails with:
Error response from daemon: exporter "image" could not be found
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
The legacy v1 is not supported by the containerd import Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
To make it possible to load emptyfs which is amd64 only Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Move opentelemetry dependencies to direct Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
emptyfs: Use newer image layout
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Fix linting issues
Fix `docker system df`
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Also moved some layerStore related initialization to the non-c8d case because otherwise they get treated as a graphdriver plugins. Co-authored-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Make the snapshotter configurable
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
c8d/pull: Add options for stargz/nydus snapshotters
let buildx know we support containerd snapshotter
This needs more work to make containerd the source of truth when it's used. It's safer for now to not try and restore any containers. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
If buildkit uses a different snapshotter we can't list the images any more because we can't find the snapshot. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Don't try to restore containers on restart with contaienrd
Pass the current snapshotter to the buildkit worker
Keeping the containerd's container around while our container is active makes `docker start` possible. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Don't remove containerd's container after exit
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
daemon: Fix not initialized network controller
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
vvoland
force-pushed
the
c8d
branch
2 times, most recently
from
5e88685 to
ac7a31e
Compare
vvoland
force-pushed
the
c8d
branch
2 times, most recently
from
13b2b08 to
ff5b724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just putting this out here in case anyone finds it useful. Seems to be required to have a sensible dev environment for this branch.
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com