fix(x509): mark dirNameTag as constructed in parseNameConstraintsExtension#54
Merged
fix(x509): mark dirNameTag as constructed in parseNameConstraintsExtension#54
Conversation
hdm
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fails to parse the dirName from a valid cert with a name constraint.
Testing:
created a valid cert with openssl v3.5.2
config something like this
gen the cert
openssl req -x509 -new -key ca.key -days 365 -out ca.crt -config openssl_ca.cnf -extensions v3_caParse the resulting cert text with excrypto inspecting the structure.
Parsing this cert previously hit the default unhandled case, this fix adjusts the case to 0xA4 and now properly parses the dirName.