Skip to content

Conversation

@Fiffers
Copy link
Contributor

@Fiffers Fiffers commented Jan 4, 2026

This update adds some new features to the custom emoji plugin and removes several others (since they're not needed anymore). The biggest change is that the plugin no longer utilizes the ChatIconManager to render the static emoji like it did in the past. This change had a lot of knock-on effects, which you'll see in the large number of removed methods in this PR. My favorite part is that it made emoji look a bit better :)
image

Added:

  • Implemented a download progress bar and status message in the panel for the plugin so the user doesn't think the github sync feature is broken and message me on discord about a bug because the download is 400+ MB in size and is taking a while.
    • All status messages previously displayed in the in-game chat are now displayed in this part of the panel. If the status message is an error related to the github address configuration failing, it will still be displayed in the chat.
  • A smiley icon to the header in the panel 😄

java_EkJPMobfOU

Changed

  • Plugin now registers a transparent placeholder image with the ChatIconManager and renders static emoji atop it. This is functionally the same as how Animated Emoji worked from the start.
  • The AnimatedEmojiOverlay has been renamed to ChatEmojiRenderer and has been repurposed to also handle static emoji rendering.
  • The OverheadAnimatedEmojiOverlay has been renamed to OverheadEmojiRenderer and has been repurposed to also handle static emoji rendering.
  • The refresh button in the panel now reloads all emoji instead.
  • The plugin metadata has been updated to reflect the current state of the plugin.
  • The README has been updated to reflect the current state of the plugin.
  • The plugin hub icon has been updated so its actually legible (attributions in README)

Removed

  • ::emojiprint command. This was causing more issues than it was solving so I just decided to remove it.
  • Emoji compatibility for split private chat messages. Since we're now rendering the emoji, I'm going to need to implement a bespoke solution that works for split chat at another time. The split chat widget seems similar outside of a missing scrollbar, but I haven't looked into it enough to say for sure.
  • All Image quantization and normalization logic. Since we're no longer using the ChatIconManager to render the images, we don't need to do this quantization stuff anymore. This resulted in the complete removal of the CustomEmojiImageUtilities class.
  • The File watcher and automatic reloads. Since the refresh button in the panel has been changed to perform a full reload, this was pruned. I also didn't like how, with the plugin running, you couldn't delete a folder if it had a folder inside it.

Those last two account for about 70% of all the line removals.

Fixed

  • Fix animated emoji resizing bug causing emoji to always parse their frames at the max height in the config. This would cause animated emoji that had resize disabled to appear really pixelated.
    java_UsLZVy0Clw

  • Fix emoji overlapping previous lines in the same message when displaying a long message

image
  • Fix suggestion overlay not working when typing a private message
  • Fix mouse clicks sometimes not working in the emoji panel
  • Fix a spacing issue when another plugin (which will NOT be named) puts a gazillion images into one message
  • Fix bug causing emoji that were updated on github to not properly update when a download is commanded

@runelite-github-app
Copy link

runelite-github-app bot commented Jan 4, 2026

@runelite-github-app
Copy link

runelite-github-app bot commented Jan 4, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

Fixed bug causing mouse clicks to sometimes be eaten in the emoji panel
Fix a spacing issue when another plugin (which will NOT be named) puts a gazillion images into one message
Fix bug causing emoji that were updated on github to not properly update when a download is commanded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant