Skip to content

RuneGPT Submission#7459

Closed
Kamran14 wants to merge 6 commits intorunelite:masterfrom
Kamran14:master
Closed

RuneGPT Submission#7459
Kamran14 wants to merge 6 commits intorunelite:masterfrom
Kamran14:master

Conversation

@Kamran14
Copy link
Copy Markdown

RuneGPT connects with LLM providers to help RuneLite users achieve their goal. With stats preloaded, each response is tailored to the user providing a unique experience.

Currently it only supports Gemini which is available to all users free of charge.
Time constraint

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app bot commented Feb 18, 2025

@Kamran14
Copy link
Copy Markdown
Author

Will update once build failures are addressed.

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 18, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 19, 2025
@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 19, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Feb 19, 2025
@Kamran14
Copy link
Copy Markdown
Author

Failures have been addressed and fixed in new commit.

@iProdigy
Copy link
Copy Markdown
Member

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Feb 19, 2025
@iProdigy
Copy link
Copy Markdown
Member

also https://github.com/polyphilz/scapegpt already exists; does this need to be a separate plugin (rather than contributing improvements to the existing plugin)

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Mar 3, 2025
use latest commit && add warning
@Kamran14
Copy link
Copy Markdown
Author

Kamran14 commented Mar 3, 2025

  • Fixed mentioned issues
  • config option was introduced while testing api key, forgot to remove
  • compressed img to 18kb, let me know if this is sufficient
  • added warning

regarding existing plugin;

  • ScapeGPT exists but is not a functional plugin as it hasn't been working for months possibly a year now based on user reviews and my own test
  • RuneGPT is open source and time to introduce new features and test end-to-end is fairly easy compared to ScapeGPT due to it having a requirement of a third party server
  • ScapeGPT's third party has not been active for a while so likely the author has abandoned the project

@YvesW
Copy link
Copy Markdown
Member

YvesW commented Mar 3, 2025

You should create an issue and/or a PR to know for sure as described in the take-over policy. Also, we have a take-over policy for this specific reason.

https://github.com/runelite/runelite/wiki/Plugin-takeover-policy

@Kamran14
Copy link
Copy Markdown
Author

Kamran14 commented Mar 3, 2025

iProdigy had submitted a PR on that repo 2 weeks ago and there has been no activity from the author; polyphilz/scapegpt#2

  • I'd rather not take over the plugin as that would require me to spin up an instance and maintain that for the backend, and likely will have to pay down the road as well
  • The approaches these two plugins take is quite different and I'd have to change most of the logic that ScapeGPT currently holds
  • ScapeGPT only works with openai currently and requires payment to use, which is against the model I'm trying to use for RuneGPT where players bring their own key

All in all, taking over ScapeGPT isn’t ideal since it would require me to maintain a backend (with potential future costs), its approach differs significantly from RuneGPT's, and it relies solely on OpenAI with a paid model, whereas RuneGPT lets players bring their own API key via Gemini which is free.

@raiyni
Copy link
Copy Markdown
Member

raiyni commented Mar 3, 2025

We aren't asking you to never change the code of the plugin you takeover.

@LlemonDuck
Copy link
Copy Markdown
Contributor

Don't block the shared ScheduledExecutorService with a call to OkHttpClient#execute. Either create your own executor which you're free to block, or use okhttp's async via enqueue (this would fit your current use case already, just switch to a callback style)

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 16, 2025
@LlemonDuck
Copy link
Copy Markdown
Contributor

closing as the above comments have not been resolved yet. feel free to resubmit when they are

@LlemonDuck LlemonDuck closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin added waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants