RuneProfile v2.1.0

[ReinhardtR]

• Cleaned up main RuneProfilePlugin class by moving features/logic into their own class.
• Added AutoSync
  • Syncs profile every 15 minutes in the background
  • Method to start a rapid sync, that syncs after 3 seconds
• Collection Notification Subscriber
  • Listens to collection chat message or popup notification (based on dinkplugin implementation) and starts a rapid sync on new item obtained.
• Collection Log Widget Subscriber
  • Subscribes to the collection logs setup script that allows the plugin to get the player’s collection log items.
  • The plugin now fires this script every time the collection log is opened, to populate the clogItems (in the PlayerDataService) that will be sent in the auto sync.
• Moved the RuneProfile button in the Collection Log window (that was based on WikiSync implementation) to the burger menu, since it will ideally not be used as often (or at all) and avoids conflicts with WikiSync.
• Removed Default Collection Log page selection from side panel. Replaced by “RuneProfile Default” right click menu option on Collection Log pages.
• Added a loot subscriber, that submits valuable drops to your RuneProfile.

[runelite-github-app]

runeprofile: a076e0810a294204dacacc688084b7aabe183c99...3fced102e49ec2b35b156aae773cd5244c9d24bf

[runelite-github-app]

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

---

Internal use only: Reviewer details Maintainer details

[pajlada]

ReinhardtR/runeprofile-plugin@a076e0810a294204dacacc688084b7aabe183c99...ReinhardtR:7a83138ac1aecbd40b39ba8999c366641596737c?w=1#diff-287e2aa2d9
Users who have previously disabled the update_on_logout config would presumably not want it automatically re-enabled, or have it auto sync during gameplay. I think it would be prudent to either keep the old config key, or do a config migration for users who had the config disabled.

ReinhardtR/runeprofile-plugin@a076e0810a294204dacacc688084b7aabe183c99...ReinhardtR:7a83138ac1aecbd40b39ba8999c366641596737c?w=1#diff-f763543038
You should return after this to not continue getting followers

ReinhardtR/runeprofile-plugin@a076e0810a294204dacacc688084b7aabe183c99...ReinhardtR:7a83138ac1aecbd40b39ba8999c366641596737c?w=1#diff-f763543038
You should return after this to not call complete afterwards

Not blocking

If you're copying decent chunks of code from other plugins, it's good to add or keep the license header as you've done in ReinhardtR/runeprofile-plugin@a076e0810a294204dacacc688084b7aabe183c99...ReinhardtR:7a83138ac1aecbd40b39ba8999c366641596737c?w=1#diff-e2542d64cc
For Dink / pajlads repos, feel free to put a small note in the readme instead if you don't want to put it in the header everywhere.

The menu entry inside the collection log disappears after using it once.

Attempting to use the menu entry for a new profile doesn't seem to create a profile. Is there another way I'm supposed to create my initial profile?

[ReinhardtR]

Thanks for the review <3

1. Update on logout config
   I now keep the old config key update_on_logout to avoid unwanted behaviour for existing users.

2. getPlayerModelDataAsync completeExceptionally
   Early returns have been added in those cases.

3. Credits
   Added inline credits to code that has been copied from other plugins. I hope it didn't come across as malicious <3

4. Collection Log Menu
   I see there was an issue where the menu widget was resetting its height, so the RuneProfile button was not visible. This should be fixed now.

And yes that button will create a profile if you don't have one.

To be clear this is the menu widget:

And this is the menu entry, for setting the default collection log page on your profile.

[iProdigy]

Added inline credits to code that has been copied from other plugins. I hope it didn't come across as malicious <3

nah it's all good - we did appreciate the header in ItemSearcher <3