Skip to content

Conversation

@mablack01
Copy link
Contributor

@mablack01 mablack01 commented Dec 21, 2025

  • Added indicators and easy filling for quantity/price
  • Fixed a few issues with marking certain flips active
  • Made tweaks to the offer overlay, now only displays outside of the GE
  • Added the ability to refresh suggestions
  • UI improvements to the Flip Assist feature

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 21, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 21, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

Fix for GE search
Made some UI improvements with the Flip Assist feature
Improvements with the flip suggestions UI panel
@riktenx
Copy link
Member

riktenx commented Dec 26, 2025

The size of your patch affects the timeline on which we look at it. You are approaching 5k lines with this patch which functionally means I may never get to reviewing it. Generally when I clear the update queue I am guaranteed to look at any diff ~1k lines or less.

@mablack01
Copy link
Contributor Author

The size of your patch affects the timeline on which we look at it. You are approaching 5k lines with this patch which functionally means I may never get to reviewing it. Generally when I clear the update queue I am guaranteed to look at any diff ~1k lines or less.

Apologies for the large request @riktenx , we've been working on a few MR's over the holidays. Would you like me to select an older commit to reduce the size of this request? I'm happy to roll this back a few commits if that helps you

@mablack01
Copy link
Contributor Author

@riktenx the initial commit was ~2k lines so I updated the referenced a commit SHA that was roughly 2,200 lines which included some vital patches to the first commit. The future commits I will add to a later MR once this is merged in since those contain bigger refactors.

@riktenx riktenx merged commit 2426a99 into runelite:master Dec 30, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants