Conversation
| ## Examples | ||
|
|
||
| Workflow-oriented runnable examples are documented in [`EXAMPLES.md`](./EXAMPLES.md). | ||
| For a suspend/resume plus shared snapshot restore workflow, see [`examples/devbox_snapshots.py`](./examples/devbox_snapshots.py). |
There was a problem hiding this comment.
this is the only example that gets a dedicated callout in the main README. why?
There was a problem hiding this comment.
llm thing I didn't catch :/
There was a problem hiding this comment.
overall looks good, but seems very similar to devbox_snapshot_resume.py. could these two be consolidated into one example?
There was a problem hiding this comment.
Thank you for the great feedback in this PR. I made changes to address the issues you highlighted. The cleanup code is a lot less hairy now.
In regards to your more general point: we could consolidate these demos but I feel like they're for slightly different use cases. I think it's better to keep them separate but this is mostly based on impressions of how I think agents and llms will process these docs.
sid-rl
left a comment
sid-rl
left a comment
There was a problem hiding this comment.
looks great! just some minor cleanup and questions
| ExampleCheck( | ||
| name="snapshot-backed devboxes stay isolated from one another", | ||
| passed=( | ||
| len( | ||
| { | ||
| source_isolated_readback, | ||
| clone_a_isolated_readback, | ||
| clone_b_isolated_readback, | ||
| } | ||
| ) | ||
| == 3 | ||
| ), |
There was a problem hiding this comment.
isn't this guaranteed to pass when the previous check passes?
There was a problem hiding this comment.
yeah, this is an artifact from when this worked differently
2 participants
Adds the last of the examples for basic devbox operations.