Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/lib/streaming-reconnection.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import { Stream } from '../streaming';
import { APIError } from '../error';

/**
* Wraps a stream with automatic reconnection on timeout.
*/
export async function withStreamAutoReconnect<Item>(
streamCreator: (offset: number | undefined) => Promise<Stream<Item>>,
getOffset: (item: Item) => number | undefined,
): Promise<Stream<Item>> {
let lastOffset: number | undefined = undefined;
let currentStream = await streamCreator(lastOffset);

async function* createReconnectingIterator(): AsyncIterator<Item> {
while (true) {
try {
for await (const item of currentStream) {
if (getOffset(item) !== undefined) {
lastOffset = getOffset(item);
}
yield item;
}
return; // Stream completed normally
} catch (error) {
if (error instanceof APIError && error.status === 408) {
// Reconnect with the last known offset
currentStream = await streamCreator(lastOffset);
continue;
}
throw error; // Not a timeout, rethrow
}
}
}

return new Stream(createReconnectingIterator, currentStream.controller);
}
29 changes: 19 additions & 10 deletions src/resources/devboxes/executions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import * as Core from '../../core';
import * as DevboxesAPI from './devboxes';
import { PollingOptions, poll } from '@runloop/api-client/lib/polling';
import { Stream } from '../../streaming';
import { withStreamAutoReconnect } from '@runloop/api-client/lib/streaming-reconnection';

export class Executions extends APIResource {
/**
Expand Down Expand Up @@ -153,11 +154,15 @@ export class Executions extends APIResource {
headers: defaultHeaders,
...options,
};
return this._client.get(`/v1/devboxes/${devboxId}/executions/${executionId}/stream_stderr_updates`, {
query,
...mergedOptions,
stream: true,
}) as APIPromise<Stream<ExecutionUpdateChunk>>;
const getStream: (offset: number | undefined) => APIPromise<Stream<ExecutionUpdateChunk>> = (offset) =>
this._client.get(`/v1/devboxes/${devboxId}/executions/${executionId}/stream_stderr_updates`, {
query: { ...query, offset: offset?.toString() },
...mergedOptions,
stream: true,
});
return withStreamAutoReconnect(getStream, (item) => item.offset) as APIPromise<
Stream<ExecutionUpdateChunk>
>;
}

/**
Expand All @@ -176,11 +181,15 @@ export class Executions extends APIResource {
headers: defaultHeaders,
...options,
};
return this._client.get(`/v1/devboxes/${devboxId}/executions/${executionId}/stream_stdout_updates`, {
query,
...mergedOptions,
stream: true,
}) as APIPromise<Stream<ExecutionUpdateChunk>>;
const getStream: (offset: number | undefined) => APIPromise<Stream<ExecutionUpdateChunk>> = (offset) =>
this._client.get(`/v1/devboxes/${devboxId}/executions/${executionId}/stream_stdout_updates`, {
query: { ...query, offset: offset?.toString() },
...mergedOptions,
stream: true,
});
return withStreamAutoReconnect(getStream, (item) => item.offset) as APIPromise<
Stream<ExecutionUpdateChunk>
>;
}
}

Expand Down
14 changes: 13 additions & 1 deletion src/streaming.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ReadableStream, type Response } from './_shims/index';
import { RunloopError } from './error';
import { APIError, RunloopError } from './error';
import { findDoubleNewlineIndex, LineDecoder } from './internal/decoders/line';
import { ReadableStreamToAsyncIterable } from './internal/stream-utils';

Expand Down Expand Up @@ -32,6 +32,18 @@ export class Stream<Item> implements AsyncIterable<Item> {
let done = false;
try {
for await (const sse of _iterSSEMessages(response, controller)) {
if (sse.event === 'error') {
let error: APIError | Error | undefined = new Error(sse.data);
try {
const errorObj = JSON.parse(sse.data);
error = new APIError(parseInt(errorObj.code), errorObj, errorObj.message, undefined);
} catch (e) {
console.error('Could not parse error message into JSON:', sse.data);
error = new Error(sse.data);
}
throw error;
}

try {
yield JSON.parse(sse.data);
} catch (e) {
Expand Down