Skip to content

Fix: use binary content type for file source uploads #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jason-rl wants to merge 1 commit into from
Closed

Fix: use binary content type for file source uploads #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 4 additions & 5 deletions src/object-uploader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ export async function uploadTarFile(

/**
* Upload a single file (text or binary).
* Always uses 'binary' content type so rage places the file as-is
* instead of extracting it (which it would do for tar/tgz).
*/
export async function uploadSingleFile(
client: RunloopSDK,
Expand All @@ -51,10 +53,7 @@ export async function uploadSingleFile(
const fileBuffer = fs.readFileSync(filePath);
const fileName = path.basename(filePath);

// Determine content type based on file
const contentType = determineContentType(fileName, fileBuffer);

return uploadBuffer(client, fileBuffer, fileName, contentType, ttlDays, isPublic);
return uploadBuffer(client, fileBuffer, fileName, 'binary', ttlDays, isPublic);
}

/**
Expand Down Expand Up @@ -136,7 +135,7 @@ async function uploadBuffer(
/**
* Determine content type based on file characteristics.
*/
function determineContentType(
export function determineContentType(
fileName: string,
buffer: Buffer
): 'text' | 'binary' | 'gzip' | 'tar' | 'tgz' {
Expand Down
Loading