Merged
Conversation
james-rl
approved these changes
Mar 10, 2026
Contributor
james-rl
left a comment
james-rl
left a comment
There was a problem hiding this comment.
Looks good to me.
As a general usability consideration that's not specifically related to this PR: I think it's always beneficial to explicitly define the expected working directory.
Comment on lines
+91
to
+97
| if (env) { | ||
| console.log(); | ||
| console.log(chalk.bold("Environment:")); | ||
| if (env.blueprint_id) console.log(` blueprint: ${env.blueprint_id}`); | ||
| if (env.snapshot_id) console.log(` snapshot: ${env.snapshot_id}`); | ||
| if (env.working_directory) | ||
| console.log(` working_directory: ${env.working_directory}`); |
Contributor
There was a problem hiding this comment.
This isn't an issue in this code, but I'm coming to the opinion that we should always set an explicit working directory. Not specifying it leads to potentially confusing default values.
Contributor
Author
There was a problem hiding this comment.
Yeah - in general doing a better job sanitizing working dir behavior would make all of this more robust...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an rli non-interactive command to fetch, format and print scenario info