Skip to content

fix(cli): show failure reason when benchmark job fails with no outcomes #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrvb-rl merged 1 commit into from
Mar 25, 2026
Merged

fix(cli): show failure reason when benchmark job fails with no outcomes #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/commands/benchmark-job/summary.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,11 @@ function printResultsTable(job: BenchmarkJob, extended: boolean = false): void {
const outcomes = job.benchmark_outcomes || [];

if (outcomes.length === 0) {
console.log(chalk.yellow("No benchmark outcomes found"));
if (job.failure_reason) {
console.log(chalk.red(`Job failed: ${job.failure_reason}`));
} else {
console.log(chalk.yellow("No benchmark outcomes found"));
}
return;
}

Expand Down
12 changes: 10 additions & 2 deletions src/commands/benchmark-job/watch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,11 @@ function printResultsTable(job: BenchmarkJob): void {
const outcomes = job.benchmark_outcomes || [];

if (outcomes.length === 0) {
console.log(chalk.yellow("No benchmark outcomes found"));
if (job.failure_reason) {
console.log(chalk.red(`Job failed: ${job.failure_reason}`));
} else {
console.log(chalk.yellow("No benchmark outcomes found"));
}
return;
}

Expand Down Expand Up @@ -478,7 +482,11 @@ export async function watchBenchmarkJob(id: string) {
const totalElapsedStr = formatDuration(Date.now() - jobStartMs);

// Show completion message
console.log(chalk.green.bold("Benchmark job completed!"));
if (job.state === "failed") {
console.log(chalk.red.bold("Benchmark job failed."));
} else {
console.log(chalk.green.bold("Benchmark job completed!"));
}
console.log(chalk.dim(`Total time: ${totalElapsedStr}`));

// Show final results (summary only)
Expand Down
Loading