Skip to content

Adding proper @ember-data package name where missing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runspired merged 2 commits into from
Nov 16, 2018
Merged

Adding proper @ember-data package name where missing #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0530d33
Adding proper @ember-data package name where missing
acorncom Nov 9, 2018
95837ac
Merge branch 'ember-data-packages-rfc' into patch-1
runspired Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions text/0000-ember-data-packages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,32 +262,32 @@ Today, presence in the `emberjs` organization on `github` also places `ember-dat
<tr>
<td>DS.JSONAPISerializer</td>
<td>import JSONAPISerializer from 'ember-data/serializers/json-api';</td>
<td>import JSONAPISerializer from 'ember-data/serializers/json-api';</td>
<td>import JSONAPISerializer from '@ember-data/serializers/json-api';</td>
</tr>
<tr>
<td>DS.Transform</td>
<td>import Transform from 'ember-data/transform';</td>
<td>import Transform from 'ember-data/transforms';</td>
<td>import Transform from '@ember-data/transforms';</td>
</tr>
<tr>
<td>DS.DateTransform</td>
<td>import DateTransform from 'ember-data/transforms/date';</td>
<td>import { DateTransform } from 'ember-data/transforms';</td>
<td>import { DateTransform } from '@ember-data/transforms';</td>
</tr>
<tr>
<td>DS.StringTransform</td>
<td>import StringTransform from 'ember-data/transforms/string';</td>
<td>import { StringTransform } from 'ember-data/transforms';</td>
<td>import { StringTransform } from '@ember-data/transforms';</td>
</tr>
<tr>
<td>DS.NumberTransform</td>
<td>import NumberTransform from 'ember-data/transforms/number';</td>
<td>import { NumberTransform } from 'ember-data/transforms';</td>
<td>import { NumberTransform } from '@ember-data/transforms';</td>
</tr>
<tr>
<td>DS.BooleanTransform</td>
<td>import BooleanTransform from 'ember-data/transforms/boolean';</td>
<td>import { BooleanTransform } from 'ember-data/transforms';</td>
<td>import { BooleanTransform } from '@ember-data/transforms';</td>
</tr>
<tr>
<td colspan="3"><h3>@ember-data/store</h3></td>
Expand Down Expand Up @@ -376,7 +376,7 @@ Today, presence in the `emberjs` organization on `github` also places `ember-dat
#### `@ember-data/model`

1) `InternalModel` and `RootState` are tightly coupled to the store and to our provided `Model`
implementation. Overtime we need to uncouple this, but given their coupling to `Model` and our
implementation. Over time we need to uncouple this, but given their coupling to `Model` and our
desire to enable them to be eliminated from projects not using `Model`, I believe these exports
belong in `@ember-data/model` for this reason.

Expand Down