Create descriptor-based wallet by default if above bitcoin v21.0+#29
Create descriptor-based wallet by default if above bitcoin v21.0+#29sandipndev wants to merge 1 commit intorust-bitcoin:masterfrom
Conversation
|
Waiting for PR RCasatta/rust-bitcoincore-rpc#1 to be merged for this to go through. |
83697fc to
887d41b
Compare
|
Based on the results from the CI, I think we may need to have something like: let desc_wallet = if cfg!(any(feature = "22_0", feature = "0_21_1", feature = "0_21_0")) {
Some(true)
}
else {
None
} |
Agreed, but maybe invert the logic to check |
887d41b to
4e3b1a1
Compare
|
CI is reliably failing for: We may want to feature gate the call to create_wallet according to the version, but I am not sure even considering that now that https://github.com/rust-bitcoin/rust-bitcoincore-rpc finally shipped with @sandipndev instead of needing this in your code could you create a new wallet with descriptor_wallet true instead of changing the default? |
When we launch the bitcoind process, the default wallet being created enables descriptor mode.