Handle async pipelined request cancellation correctly#488
Merged
tcharding merged 1 commit intorust-bitcoin:masterfrom Jan 29, 2026
Merged
Conversation
tnull
approved these changes
Jan 29, 2026
It turns out if we get a pipelined request and it is cancelled (by dropping the `Future` reading the response), we'll end up infinite-looping all future requests on the connection waiting for their turn to read that will never come. Instead, we have to manually detect `Future` drops and retry later requests. Fixes rust-bitcoin#487
TheBlueMatt
force-pushed
the
2026-01-pipelined-cancel-safety
branch
from
20c4ba6 to
5c2b089
Compare
Member
Author
|
FIxed rustfmt. |
Member
|
Oh woops, I included a mention in the merge commit now you will get spammed if/when anyone forks this repo - sorry @tnull. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out if we get a pipelined request and it is cancelled (by dropping the
Futurereading the response), we'll end up infinite-looping all future requests on the connection waiting for their turn to read that will never come.Instead, we have to manually detect
Futuredrops and retry later requests.Fixes #487