Remove unused argument on CheckedHrpstring::fe32_iter#220
Closed
stevenroose wants to merge 1 commit intorust-bitcoin:masterfrom
Closed
Remove unused argument on CheckedHrpstring::fe32_iter#220stevenroose wants to merge 1 commit intorust-bitcoin:masterfrom
stevenroose wants to merge 1 commit intorust-bitcoin:masterfrom
Conversation
Closed
Member
|
ACK f293b34 |
apoelstra
added a commit
that referenced
this pull request
Aug 2, 2025
7a3f493 ci: update checkout and cache to v4; runner to ubuntu-latest. (Andrew Poelstra) 62a9d53 add weekly cronjob to update nightly-version (Andrew Poelstra) 4c00b93 introduce nightly-version file (copied from rust-bitcoin) and use it in CI (Andrew Poelstra) 720992b clippy: fix new lifetime lint (Andrew Poelstra (aider)) Pull request description: Right now I can't test #220 or #221 locally because clippy is failing with the latest nightly. I can disable the local clippy check but I'd prefer to fix it here. Should unblock both those PRs. ACKs for top commit: clarkmoody: ACK 7a3f493 Tree-SHA512: 725177b18bce543c6c114ce0ee6ef04bc6862c440a2fff9b99d607b912f6ab2c0eab22ecf03abc89332519aa9ffc4ddd624d16abfce0c6d4fefad53a87eb5249
Member
|
Needs rebase since #223 -- sorry, I added an extra lifetime parameter on the same function definition that you're fixing. |
tcharding
added a commit
to tcharding/rust-bech32
that referenced
this pull request
Jan 16, 2026
This is Steven's work in the now very old rust-bitcoin#220. Its a one line change so just pick it up and push it in. FTR no one knows how or why this is here. Its probably my fault ...
Member
|
I picked this up: #235 |
apoelstra
added a commit
that referenced
this pull request
Jan 25, 2026
6487797 Remove unused argument on CheckedHrpstring::fe32_iter (Tobin C. Harding) Pull request description: This is Steven's work in the now very old #220. Its a one line change so just pick it up and push it in. FTR no one knows how or why this is here. Its probably my fault ... ACKs for top commit: apoelstra: ACK 6487797; successfully ran local tests; lol let's get this in Tree-SHA512: 4e4e7b0a6a93821194ec2e1fa118faf7f0f91ba1fe7a2975e4e2be73bede0dcca7128749adebbeb31d3018653ccbe0930f8761bb412207a79fb0dcd854d20912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to solve #193 (comment)