Re-write CI to use cargo-rbmt#234
Closed
tcharding wants to merge 1 commit intorust-bitcoin:masterfrom
Closed
Conversation
tcharding
force-pushed
the
push-rktvkspkpnzz
branch
2 times, most recently
from
7878dae to
b027f3b
Compare
tcharding
force-pushed
the
push-rktvkspkpnzz
branch
from
b027f3b to
1f51374
Compare
Re-write CI to use the `cargo-rbmt` tool [0] This is quite an overhaul, some notes: - Adds action to install `cargo-rbmt` directly from the repo - Upgrades to checkout v5 (and uses explicit commit hash) - Uses ubuntu-24.04 instead of latest (I can't remember why we did this) - Defaults jobs to no permissions and uses read in each job - Gets the MSRV from manifest instead of explicitly - Removes the `Beta` toolchain test - Introduce lock files - Remove clippy.toml (because clippy can parse manifests now) [0] https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools/tree/master/cargo-rbmt
tcharding
force-pushed
the
push-rktvkspkpnzz
branch
from
1f51374 to
8329486
Compare
Member
|
FYI I'm happy to review this if we can get it working. This crate is currently pretty annoying for me to test because it doesn't have embedded lockfiles. |
Member
Author
|
For me or anyone else rust-bitcoin/rust-bitcoin#5549 is the PR that introduces |
Member
Author
|
Replaced by #254 |
apoelstra
added a commit
that referenced
this pull request
Apr 21, 2026
30686ad tests: fix cfg-gated variables/helpers in primitives tests (satsfy (Renato Britto)) 6902800 build: migrate ci to cargo rbmt (satsfy (Renato Britto)) Pull request description: This PR migrates CI from `contrib/test.sh` to `cargo rbmt`. It continues PR #234. It also: - adds minimal and recent lockfiles for CI - declares `rust-version = "1.56.1"` in `Cargo.toml` - adds rbmt toolchain metadata - removes the old `contrib/test.sh` workflow - updates the workflow to use the pinned upstream `setup-rbmt` action - simplifies the embedded jobs into a matrix - drops the stale mutagen lint override No library behavior is intended to change. ACKs for top commit: tcharding: ACK 30686ad apoelstra: ACK 30686ad; successfully ran local tests Tree-SHA512: 3f7003b3c891d387f5bba98c2c5432d723ff1a830dec50e786ed9e86ee0cad07af4f23edf0dbbb6ae3d332898ecdb91d4f0c4e524f9085203616d4dd5e0c3a03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-write CI to use the
cargo-rbmttool [0]This is quite an overhaul, some notes:
cargo-rbmtdirectly from the repoBetatoolchain test[0] https://github.com/rust-bitcoin/rust-bitcoin-maintainer-tools/tree/master/cargo-rbmt