Skip to content

ci: unify nightly versions in Cargo.toml#259

Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom
satsfy:unify-nightly-pins
Apr 23, 2026
Merged

ci: unify nightly versions in Cargo.toml#259
apoelstra merged 2 commits intorust-bitcoin:masterfrom
satsfy:unify-nightly-pins

Conversation

@satsfy
Copy link
Copy Markdown
Contributor

@satsfy satsfy commented Apr 22, 2026

Follow up from #254 (comment)

After the rbmt CI migration, most jobs were already consuming nightly from [package.metadata.rbmt.toolchains] in Cargo.toml, but the weekly updater still wrote nightly-version. This change makes Cargo.toml the single nightly source of truth across the updater and CI jobs.

Changes:

  • update weekly nightly cron to use cargo rbmt toolchains --update-nightly. Replicates rust-bitcoin CI closely.
  • nightly-version removed.
  • migrate Embedded CI job to read nightly from Cargo.toml instead of nightly-version.

Validated in personal fork CI:

Comment thread .github/workflows/cron-weekly-update-nightly.yml Outdated
@apoelstra
Copy link
Copy Markdown
Member

Can you just copy the files from rust-bitcoin so that I can diff them rather than re-reviewing? You might need to change the token but that should be it.

@satsfy satsfy force-pushed the unify-nightly-pins branch from cf7af81 to 054b39b Compare April 22, 2026 21:17
@satsfy
Copy link
Copy Markdown
Contributor Author

satsfy commented Apr 22, 2026

It now mirrors rust-bitcoin's version in everything but 1. absent eval and 2. the repo specific token.

Validated again with this CI run creating this branch in my local CI.

Side question: Why don't we have a central CI repo for reusable workflows and shared actions (maybe just import from rust-bitcoin directly), and keep a tiny workflow file in each repo that only calls into that central logic?

Comment thread .github/workflows/rust.yml Outdated
@nyonson
Copy link
Copy Markdown

nyonson commented Apr 22, 2026

Side question: Why don't we have a central CI repo for reusable workflows and shared actions (maybe just import from rust-bitcoin directly), and keep a tiny workflow file in each repo that only calls into that central logic?

I have been attempting that with the actions in rust-bitcoin-maintainer-tools, but been finding them to be more trouble than they are worth since rbmt contains the bulk of the logic. Might be easier for repos to just copy/pasta something like this into their own repo since it won't change much.

@satsfy satsfy force-pushed the unify-nightly-pins branch from 054b39b to b8a32c9 Compare April 22, 2026 22:10
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b8a32c9; successfully ran local tests

@tcharding
Copy link
Copy Markdown
Member

Since you already diff'ed I can't add anything by reviewing this. But FWIW concept ACK.

@apoelstra apoelstra merged commit 437c0c6 into rust-bitcoin:master Apr 23, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants