ci: unify nightly versions in Cargo.toml#259
Conversation
|
Can you just copy the files from rust-bitcoin so that I can diff them rather than re-reviewing? You might need to change the token but that should be it. |
cf7af81 to
054b39b
Compare
|
It now mirrors rust-bitcoin's version in everything but 1. absent Validated again with this CI run creating this branch in my local CI. Side question: Why don't we have a central CI repo for reusable workflows and shared actions (maybe just import from rust-bitcoin directly), and keep a tiny workflow file in each repo that only calls into that central logic? |
I have been attempting that with the actions in rust-bitcoin-maintainer-tools, but been finding them to be more trouble than they are worth since rbmt contains the bulk of the logic. Might be easier for repos to just copy/pasta something like this into their own repo since it won't change much. |
054b39b to
b8a32c9
Compare
|
Since you already diff'ed I can't add anything by reviewing this. But FWIW concept ACK. |
Follow up from #254 (comment)
After the rbmt CI migration, most jobs were already consuming nightly from
[package.metadata.rbmt.toolchains]inCargo.toml, but the weekly updater still wrotenightly-version. This change makesCargo.tomlthe single nightly source of truth across the updater and CI jobs.Changes:
cargo rbmt toolchains --update-nightly.Replicates rust-bitcoin CI closely.nightly-versionremoved.Cargo.tomlinstead ofnightly-version.Validated in personal fork CI: