Enable edition 2018#365
Merged
sanket1729 merged 4 commits intorust-bitcoin:masterfrom May 2, 2022
Merged
Conversation
tcharding
force-pushed
the
edition-2018
branch
2 times, most recently
from
3e2f6e7 to
b15c15d
Compare
tcharding
force-pushed
the
edition-2018
branch
2 times, most recently
from
900ae8a to
9bbef67
Compare
Member
|
I think the MSRV change can go in any order. I would like to get an external contributor #339 PR in first before we address this. That already has ACK from me, but would also like Andrew's ACK(it's a somewhat big change) before we proceed with it. |
apoelstra
previously approved these changes
Apr 30, 2022
Member
|
Sorry, this now conflicts after we got #339 in |
Change the version of bitcoin to the latest 0.28 release.
It seems we have consensus within the rust-bitcoin github organisation on bumping the MSRV to 1.41.1, update CI job and the README to reflect this.
Use `cargo fix --edition` to update the codebase to edition 2018, the only changes made are adding `crate::` prefix to use statements. In addition; do a bunch of manual additions of `crate::`. Includes `integration_test` crate also.
Run `cargo fix --edition-idioms`. This fixes uses of 'extern crate' and also lifetimes that the compiler can infer.
Member
Author
|
Changes in force push:
|
Member
Author
|
FTR please do not worry about merge conflicts caused by this PR in relation to any of my other PRs, I'm fine to rebase. |
sanket1729
approved these changes
May 2, 2022
Member
sanket1729
left a comment
sanket1729
left a comment
There was a problem hiding this comment.
ACK c60bf1e. redid the entire process to match the diff.
Member
Author
|
BOOM! The first edition 2018 PR to be merged across the stack, way to go! |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
c60bf1e1134acfe3cc60b46f80651672d2e70771 Fix edition-idioms (Tobin C. Harding) 08bce7a11d3e9bc2dbacc760015766eba0c35527 Update to use edition 2018 (Tobin C. Harding) 2a83fa0d4ca28dc916501e85ca5aa781b02118e1 Update MSRV in CI and Readme from 1.29 to 1.41.1 (Tobin C. Harding) 2b73bb28c0f57f16451395748758a751f4e63449 integration_test: Use latest bitcoin release (Tobin C. Harding) Pull request description: Update the MSRV to Rust 1.41.1 and enable edition 2018. I'm not sure how we want to merge these MSRV PRs across the stack but here is the `rust-miniscript` one. Discussion: rust-bitcoin/rust-bitcoin#510 (comment) ACKs for top commit: sanket1729: ACK c60bf1e1134acfe3cc60b46f80651672d2e70771. redid the entire process to match the diff. Tree-SHA512: 353cd793df4ba91b897e0dc58547b074ade7c23e7d75447c957ba947a12ff72c4504cb46036fdffea1591e429ee9eb056182dcffc89e301c72e3c5c433e8de16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the MSRV to Rust 1.41.1 and enable edition 2018.
I'm not sure how we want to merge these MSRV PRs across the stack but here is the
rust-miniscriptone.Discussion: rust-bitcoin/rust-bitcoin#510 (comment)