Fix compilation of pk()-only policies into tr() descriptors#677
Fix compilation of pk()-only policies into tr() descriptors#677apoelstra merged 2 commits intorust-bitcoin:masterfrom
Conversation
|
Thanks for the contribution! Can you put the unit test as a separate patch after the fix please so that during review I can swap them around and verify the failure. |
shesek
force-pushed
the
202404-tr-pk-only
branch
from
956f482 to
bb6347f
Compare
|
@tcharding Yes for sure, I updated my branch. |
|
Bother, the CI fail is unrelated to this PR. I hit the same thing elsewhere yesterday, I'll push a PR to fix it (it requires dependency pinning). |
|
I verified the unit test does indeed fail and the fix does fix the test. I have no view on the sanity of the change, requires @apoelstra or @sanket1729 who actually know this crate. I'm just the code monkey :) Thanks for the contribution. |
|
It's been a while since I looked at MSRV things. What is the current rust-bitcoin MSRV? The CI is failing at
|
|
Will need rebasing once #678 goes in. |
Prior to this fix, the test failed with: `Unexpected("Empty Miniscript compilation")`
shesek
force-pushed
the
202404-tr-pk-only
branch
from
bb6347f to
ea3c523
Compare
|
I'm gonna go ahead and merge this. My local tests pass and I've been recently reading this code (hence my breaking it :)) so I'm fairly confident I understand it. |
Pending a release with rust-bitcoin/rust-miniscript#677
…policies into tr() descriptors
ea3c523b1c0b52069ca2b80e1b07bb275a3ebe9a Add test case for compilation of pk()-only policies (Nadav Ivgi)
169e4895d916069a0d2e12bf763c7eee0f55a9c4 Fix compilation of pk()-only policies into tr() descriptors (Nadav Ivgi)
Pull request description:
Before this fix, the added test failed with: `Unexpected("Empty Miniscript compilation")`
ACKs for top commit:
apoelstra:
ACK ea3c523b1c0b52069ca2b80e1b07bb275a3ebe9a successfully ran local tests; good find!
Tree-SHA512: 3d19d4f23f21d4c811ddb1e0a3cc66f0bc90cffe47f4d5a0659caa44b0d80a0665e71b46b8289f1efba98ba4cf731eac8bc7d1fc7b5a3d701cf5c85b48fc5551
Pending a release with rust-bitcoin/rust-miniscript#677
4 participants
Before this fix, the added test failed with:
Unexpected("Empty Miniscript compilation")