DM reviewer on zulip if they approve a PR which cannot be merged

[lcnr]

E.g. rust-lang/rust#149904 (comment) or rust-lang/rust#149389 (comment)

I tend to @bors r+ PRs and then don't wait for bors to actually state that it is in the merge queue.

In case a PR cannot be merged because it is still blocked, it would be nice to get a separate notifications through zulip. One of these PRs ended up not getting merged for 2 weeks as I stopped thinking about it after its approvial.

[Kobzol]

Hmm, I'm not sure how to distinguish when we should notify on Zulip vs when not. When you send @bors r+, bors responds "immediately", so it kinda expects you to wait for the response and read it xD You should also get an e-mail notification about the response comment if you don't read it immediately in the PR.

[lcnr]

I think zulip DMs by bots are low cost and I would always want them if the r+ gets rejected

[Kobzol]

Well, the cost is mostly in the design aspects 😆 I don't want to be DMed by bors in similar cases, because I simply wait for its response on GitHub, and I imagine (some) others will have it the same. Should it also send a message when you r+ a PR and then its PR CI fails? Which specific messages should be elevated to be Zulip notifications? Should we make this configurable somehow (per-user)?

I wonder if the real problem here is that the response to r+ is too slow, so you don't want to wait for it?

[Kobzol]

Or even in blocking approvals for S-blocked and S-waiting-on-team? Maybe we should reduce the set of labels that block approvals? It's quite broad at the moment.

[lcnr]

hmm, I do feel opposed to waiting until bors replies and to me PR CI failing is different as it doesn't happen immediately. But yeee 🤔

I am going to try wait for the bors reply and see whether that's actually fine for me :>