-Znext-lockfile-bump: Don't suggest using -Z on stable #12302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @epage (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-dependency-resolution
Contributor
|
@bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
bors
added a commit
that referenced
this pull request
Jun 22, 2023
-Znext-lockfile-bump: Don't suggest using -Z on stable This changes the lockfile version 4 error to not suggest using `-Znext-lockfile-bump` on the stable channel. I fear this could be confusing to users when the real version 4 is stabilized, and the user is using a too old version of cargo. Instead this produces the same error message as any unknown version would produce, with a suggestion to update.
Member
|
@bors r+ |
Contributor
|
💡 This pull request was already approved, no need to approve it again.
|
Contributor
Contributor
Member
|
On no my GitHub page has been cached 😆 |
Contributor
|
☀️ Test successful - checks-actions |
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 24, 2023
Update cargo 8 commits in 4cebd130ebca3bc219180a54f3e26cc1b14a91de..03bc66b55c290324bd46eb22e369c8fae1908f91 2023-06-21 18:59:29 +0000 to 2023-06-23 23:27:46 +0000 - fix(script): Be quiet on programmatic output (rust-lang/cargo#12305) - docs(unstable): Update script documentation (rust-lang/cargo#12308) - cargo script example needs nightly -Zscript feature (rust-lang/cargo#12287) - fix(script): Process config relative to script, not CWD (rust-lang/cargo#12303) - -Znext-lockfile-bump: Don't suggest using -Z on stable (rust-lang/cargo#12302) - build(deps): bump openssl from 0.10.54 to 0.10.55 (rust-lang/cargo#12300) - Add `.toml` file extension restriction for `-Zconfig-include` (rust-lang/cargo#12298) - docs(unstable): Point stable-unstable docs to nightly docs (rust-lang/cargo#12299) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the lockfile version 4 error to not suggest using
-Znext-lockfile-bumpon the stable channel. I fear this could be confusing to users when the real version 4 is stabilized, and the user is using a too old version of cargo. Instead this produces the same error message as any unknown version would produce, with a suggestion to update.