add weak memcpy et al (take 2) #15
Closed
+57
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Splitting rlibc into its own crate yields correct But using this crate still generates a recursive bomb. |
Member
|
So is the problem inside the rlibc crate? Is the |
Contributor
Author
|
The rlibc disassembly loosk correct. Interestingly, disabling LTO on this branch doesn't fix the infinite recursion. |
Member
|
|
| #[cfg(test)] | ||
| extern crate core; | ||
|
|
||
| extern crate rlibc; |
Member
There was a problem hiding this comment.
I don't think an extern crate is necessary here since you're getting the symbols using extern "C".
tgross35
pushed a commit
to tgross35/compiler-builtins
that referenced
this pull request
Feb 23, 2025
91: Implement exp2 and exp2f r=japaric a=porglezomp Closes rust-lang#15 Closes rust-lang#16 Co-authored-by: C Jones <code@calebjones.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Amanieu