Skip to content

Conversation

@Amanieu
Copy link
Member

@Amanieu Amanieu commented Aug 13, 2016

  • Cleaned up div implementation and added the rest of the unsigned division builtins
  • Added integer multiply builtins
  • Added shift builtins
  • Removed absv
  • Disabled no_mangle for tests so we can compare with the native version
  • Optimized the ARM asm a bit

@japaric
Copy link
Contributor

japaric commented Aug 13, 2016

Awesome! Looks good to me, but there's an issue around tests:

Quickcheck is biased in its generation of integer values; it only generates values in a small range ([-100, 100]) (cf BurntSushi/quickcheck#119), so these tests won't hit important branches that e.g. deal with overflow. This is why I was generating a u64 from 2 u32s in the udiv* tests. I'm going to land this and we can address the test coverage later in a more general way.

On another note, I re-measured my u64 % u64 program and this PR brings the binary size down to 946 bytes, which is 30 bytes smaller than the compiler-rt.rs version 👍.

@japaric japaric merged commit 7ac5155 into rust-lang:master Aug 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants