controllers/github/secret_scanning: Add support for Trusted Publishing tokens #11405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
19 tasks
This will allow us to test with other payloads in the future.
Turbo87
force-pushed
the
trustpub-scanning
branch
from
fa1788b to
53f6695
Compare
LawnGnome
approved these changes
Jun 23, 2025
Contributor
LawnGnome
left a comment
LawnGnome
left a comment
There was a problem hiding this comment.
LGTM.
For what it's worth, I do think we should figure out a notification strategy here, since it'll probably indicate some sort of CI compromise, but that can be a follow up PR. (E-mailing all the owners feels fine to me as a first step.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the final todo item of the Trusted Publishing backend work (see #10247).
If a passed in token is successfully parsed as a Trusted Publishing token, the token is automatically revoked and a warning is logged.
Since these tokens belong to a crate (or multiple) instead of a user I have not implemented email notifications for them (yet). Should we email all owners of the crate in case a Trusted Publishing token is leaked? I guess we could also implement that in a follow-up PR, if we decide that we want that.