Make source files sidebar scrolling independant

[GuillaumeGomez]

Fixes #1474

Peek.2021-08-25.14-59.mp4

Question now: do you want to put the "hide files" button outside of the scrolled area so it always remain on top or not?

[Nemo157]

It doesn't look like this works to me? https://ipvold-docs-rs-dev.nemo157.com/crate/dialectic-tokio-serde/0.1.0/source/Cargo.lock still has the list stuck to the top of the page.

Also https://ipvold-docs-rs-dev.nemo157.com/crate/dialectic-tokio-serde/0.1.0/source/ is empty.

[GuillaumeGomez]

I can't see your pages for "dialectic-tokio-serde". Also: the scrollbar only appears when the source file list is longer than the source code.

[GuillaumeGomez]

Ah hold on! Just understood: the issue meant that we want to have the source files list always visible whatever the scroll position in the source file. Ok, I'll update.

[GuillaumeGomez]

Ok, updated. I discovered position: sticky. That was quite the ride. I added a video too.

[Nemo157]

Is it possible to not have it scroll off the top when you scroll to the very bottom?

[GuillaumeGomez]

Not that I know of. The footer is "pushing" the content up, which is why the sticky position is being disabled at that time.

[Nemo157]

On https://ipvold-docs-rs-dev.nemo157.com/crate/tokio/1.3.0/source/src/io/util/async_buf_read_ext.rs I need to scroll the page all the way down to see the last few entries in the file list. I wonder if it should be reduced in height to account for the entire header block (which might also fix the footer pushing it up). That might leave a bit of blank space below it, but that seems better than not being able to access the files.

[GuillaumeGomez]

Oh nice! That's a bug. :)

[GuillaumeGomez]

Fixed the bug, great catch, thanks!

[GuillaumeGomez]

Anything else to be fixed @Nemo157 ?

[jyn514]

This is great, thanks :)