Add global alert to notify users about upcoming breaking changes#409
Merged
emilyalbini merged 2 commits intorust-lang:masterfrom Sep 18, 2019
Merged
Add global alert to notify users about upcoming breaking changes#409emilyalbini merged 2 commits intorust-lang:masterfrom
emilyalbini merged 2 commits intorust-lang:masterfrom
Conversation
3 tasks
Mark-Simulacrum
approved these changes
Sep 16, 2019
Member
Mark-Simulacrum
left a comment
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
But I'm not very familiar with the templating code.
Member
Author
|
Did some really basic "user research", and I changed the alert color to red. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an alert in the navigation bar of each page to alert everyone of the changes in #407. It links to the blog post prepared in rust-lang/blog.rust-lang.org#403, so it should be merged only after the post is published (and ideally shortly after).
The alert can be easily disabled or customized in the source code, so it's safe to keep the code even when it's not used anymore.
r? @Mark-Simulacrum @QuietMisdreavus