allow building locally as well as with docker#467
Merged
emilyalbini merged 4 commits intorust-lang:masterfrom Nov 5, 2019
Merged
allow building locally as well as with docker#467emilyalbini merged 4 commits intorust-lang:masterfrom
emilyalbini merged 4 commits intorust-lang:masterfrom
Conversation
If docker uses the .rustwide directory, it will only be readable and writable by root. This uses a different scratch directory so that the .rustwide directory can be used for local builds.
Member
Author
|
This means that artifacts aren't cached between the container and the host, which was the original idea behind using the default directory. Unfortunately I don't see a way around this, I ran into the same problem in #432 and I think we decided there's not a good way to map permissions. |
emilyalbini
reviewed
Nov 4, 2019
Member
emilyalbini
left a comment
emilyalbini
left a comment
There was a problem hiding this comment.
Is the new directory in .gitignore and .dockerignore?
Member
Author
Good catch! |
((a=a+1)) is not defined in posix sh
Member
Author
|
This is ready for review. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If docker uses the
.rustwidedirectory, it will only be readable and writable by root.This uses a different scratch directory so that the
.rustwidedirectory can be used for local builds.