Merged
Conversation
See rust-lang#671, servo/html5ever#414 for rationale. This makes the `extract_head_and_body` function public since I couldn't find a cfg flag that would do so only during tests.
Merged
Member
|
Looks good to me. I guess the idea is to gather benchmarks before/after changes locally? Feel free to merge. |
Member
Author
Right, this would give me some idea of 'is rendering faster or slower after switching to kuchiki' without having to deploy to prod and possibly have the site go down again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #671, servo/html5ever#414 for rationale.
This makes the
extract_head_and_bodyfunction public since I couldn'tfind a cfg flag that would do so only during tests.
This does not run benchmarks in CI, but makes it easy to do so locally. I plan to run benchmarks whenever dependencies are updated in the future.