Support sticky redirects in git2-curl. #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This seems a little hacky, but there needs to be some way to bubble up the base path to the I tested against gitlab and it seems to solve the issue, otherwise I'm not sure what other testing would be appropriate. |
If you use a gitlab url such as "https://gitlab.com/user/repo", then gitlab will redirect the first GET request to "https://gitlab.com/user/repo.git" (with the `.git` at the end). However, gitlab does not redirect the next POST, causing a 404. This change keeps track of the original redirect so that subsequent actions use the new base url. This roughly mirrors what is done in libgit2's transport. Fixes rust-lang/cargo#6114
Member
|
Oh jeez, that really is pretty icky! I think this is good enough for now though. I may have been a bit too conservative in requiring things to be threadsafe, and that'd make this much nicer with interior mutability via |
Member
|
I've included this in 0.8.2 and folded the version bump into rust-lang/rust#54919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use a gitlab url such as "https://gitlab.com/user/repo", then gitlab will
redirect the first GET request to "https://gitlab.com/user/repo.git" (with the
.gitat the end). However, gitlab does not redirect the next POST, causing a404. This change keeps track of the original redirect so that subsequent actions
use the new base url. This roughly mirrors what is done in libgit2's transport.
Fixes rust-lang/cargo#6114