Conversation
| } | ||
|
|
||
| #[test] | ||
| #[allow(clippy::needless_borrow)] |
There was a problem hiding this comment.
Just because cargo clippy --all --tests --features serde,rayon,bumpalo -- -D clippy::all started returning an error
|
☔ The latest upstream changes (presumably #366) made this pull request unmergeable. Please resolve the merge conflicts. |
Amanieu
left a comment
Amanieu
left a comment
There was a problem hiding this comment.
There's quite a few typos, I've corrected some of them but the same typos appear in other comments as well.
|
Overall, this looks great! Thanks for helping document the API! |
Well, I tried to make documentation for the `basket`, and tried to do it correctly. But maybe I missed something. You can freely edit, add or even throw everything out if necessary.
JustForFun88
force-pushed
the
doc_bucket
branch
from
7923a8f to
136fccb
Compare
|
Hmm... new clippy lints. Ok I'll fix it tonight |
I'm very sorry for the long break. Tried to make changes and corrections. Unfortunately, English is not my native language, so I apologize for possible mistakes and typos. Can you check again? |
|
@bors r+ |
|
☀️ Test successful - checks-actions |
3 participants
Well, I tried to make documentation for the
bucket, and tried to do it correctly. But maybe I missed something. You can freely edit, add or even throw everything out if necessary 🙂.