CI: Improve msrv checking and speedup CI#74
Merged
weihanglo merged 17 commits intorust-lang:mainfrom Mar 11, 2024
Merged
Conversation
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
macos-14 uses M1, it's much faster than macos-latest Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
So that it knows which specific version is used to invalidate caching. Also, on 1.63 fetching from registry is especially slow, running `cargo +stable update` befoe this can speed it up a little bit. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
It uses `-Zminimal` to use minimal versions. It also avoids compilation to speedup CI as much as possible. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
epage
reviewed
Mar 3, 2024
epage
reviewed
Mar 3, 2024
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
epage
reviewed
Mar 6, 2024
epage
reviewed
Mar 6, 2024
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
epage
approved these changes
Mar 8, 2024
epage
left a comment
epage
left a comment
There was a problem hiding this comment.
For CI. I don't deal enough with this to speak to the test changes
weihanglo
reviewed
Mar 10, 2024
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Thanks for working on this. Glad to see the huge improvement on CI time!
I'd love to have a clearer git history. It doesn't mean we need to squash commits. Just let it make more sense and remove some intermediate commits during the development.
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
weihanglo
approved these changes
Mar 11, 2024
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Given both CI and test are reviewed, I am going to merge this. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve msrv CI:
Cargo.lockcreated usingcargo +nightly -Zminimal-versions updateand used in msrv job to make sure it tests against the minimal version of dependencies.cargo-checkto check for msrv (in a new job), runningcargo-testwould also pull in test dependencies and test codeThis PR also speeds up the CI from 5m down to 1m (when make and dependencies are cached).