plain libc close(fd) is unreliable on MacOSX

[DanielJoyce]

Should probably switch to the methods reccomended here

lionheart/openradar-mirror#4506

An alternative version available on Mac OS X, close$NOCANCEL$UNIX2003 (32-bit x86) and close$NOCANCEL (x86_64) is available.

[DanielJoyce]

Oops, just saw its being used!

[DanielJoyce]

https://github.com/rust-lang/libc/blob/19f3be3638322e343f90c50ec8d30de9e4972940/src/unix/mod.rs

Line 407, so its all good.

[DanielJoyce]

Oops, looks like it reccomends the NOCANCEL variant, so reopening

[alexcrichton]

Oh seems like a great thing to change! Do you know the version compatibility for this symbol? For us it just needs to be present on OSX 10.7+ to use it everywhere, if it's available on less OS-es we'll just have to tread more carefully.

[DanielJoyce]

Sorry I am no mac expert. Just working on a rust serial lib. https://codereview.chromium.org/23455051/ According to this chromium bug it's at least available 3 years ago.

On Tue, May 16, 2017, 16:41 Alex Crichton ***@***.***> wrote: Oh seems like a great thing to change! Do you know the version compatibility for this symbol? For us it just needs to be present on OSX 10.7+ to use it everywhere, if it's available on less OS-es we'll just have to tread more carefully. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#595 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA50lvaF31YQQjON_3aF84qTj4RvwPXFks5r6jRDgaJpZM4Nc1qa> .

-- Daniel Joyce The meek shall inherit the Earth, for the brave will be among the stars.

[Susurrus]

@alexcrichton Is linking done as part of compilation or testing of libc? I can set the link name to anything and the build succeeds on my mac. But at least on my Mac that's running 10.9.5 the functions exist.

[alexcrichton]

Nah unfortunately we don't have many OSX 10.7 machines to test on. Also to be clear it's still possible to update what libc itself uses without impacting rust-lang/rust. We'd just not use libc::close in that case. I'd just like to be aware of the verison compatibility of this symbol

[Susurrus]

@alexcrichton I think we're in the clear. I believe $NOCANCEL variants were added in 10.6 according to this source.

[alexcrichton]

Awesome! In that case sounds like a PR would work marvelously here

[Susurrus]

@DanielJoyce Interested in taking the lead on this, otherwise I can get to this today.

[DanielJoyce]

Pretty busy today.

On Thu, May 18, 2017, 08:42 Susurrus ***@***.***> wrote: @DanielJoyce <https://github.com/danieljoyce> Interested in taking the lead on this, otherwise I can get to this today. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#595 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA50lgR8t5V_J2ObUHRvmrI4Bx7PjwDXks5r7Gb5gaJpZM4Nc1qa> .

-- Daniel Joyce The meek shall inherit the Earth, for the brave will be among the stars.

[Susurrus]

Then I'll go ahead and take care of this.