Fix FreeBSD ioctl request constants#1025
Closed
dcuddeback wants to merge 1 commit intorust-lang:masterfrom
dcuddeback:feature/fix-freebsd-ioctls
Closed
Fix FreeBSD ioctl request constants#1025dcuddeback wants to merge 1 commit intorust-lang:masterfrom dcuddeback:feature/fix-freebsd-ioctls
dcuddeback wants to merge 1 commit intorust-lang:masterfrom
dcuddeback:feature/fix-freebsd-ioctls
Conversation
On FreeBSD `ioctl()` is defined as taking `c_ulong` as the `request`
parameter:
fn ioctl(fd: c_int, request: c_ulong, ...) -> c_int
Constants meant to be passed as the `request` parameter should be
defined as `c_ulong` to avoid requiring explicit type casts. These
constants were being defined as a mixture of `c_uint` and `c_ulong`.
This commit changes ioctl request constants on FreeBSD to `c_ulong`.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Author
|
Duplicate of #704. Sorry, I overlooked that there was an existing PR before opening this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On FreeBSD
ioctl()is defined as takingc_ulongas therequestparameter:Constants meant to be passed as the
requestparameter were being defined as a mixture ofc_uintandc_ulong, which can cause type errors. For example, the following programresults in a type error:
This commit changes ioctl request constants on FreeBSD to
c_ulong, which fixes the compilation error in the above test program.