solaris based systems update#2236
solaris based systems update#2236bors merged 1 commit intorust-lang:masterfrom devnexen:solarish_update
Conversation
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
src/unix/solarish/mod.rs
Outdated
| pub fn rand() -> ::c_int; | ||
| pub fn srand(seed: ::c_uint); | ||
| pub fn getentropy(buf: *mut ::c_void, buflen: ::size_t) -> ::c_int; | ||
| pub fn getrandom(bbuf: *mut ::c_void, buflen: ::size_t, flags: ::c_uint); |
There was a problem hiding this comment.
Shouldn't getrandom return ssize_t?
There was a problem hiding this comment.
oh right I just forgot the return type
There was a problem hiding this comment.
Is using the same type for Illumos and Solaris correct here? rand/getrandom used to use different return types for getrandom for these two OSes (see e.g. rust-random/rand#730), and glibc also mentions Solaris having a non-standard return type (here).
(I came here while investigating rust-lang/miri#3924.)
basis to do cpu affinity with some illumos specifics.
|
@bors r+ |
|
📌 Commit 68ec7f2 has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
6 participants
basis to do cpu affinity with some illumos specifics.