Skip to content

linux SOMAXCONN rework proposal.#2808

Merged
bors merged 1 commit intorust-lang:masterfrom
devnexen:linux_somaxconn_rework
May 31, 2022
Merged

linux SOMAXCONN rework proposal.#2808
bors merged 1 commit intorust-lang:masterfrom
devnexen:linux_somaxconn_rework

Conversation

@devnexen
Copy link
Contributor

glibc had increased to 4096 since couple of years already.

glibc had increased to 4096 since couple of years already.
@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's enough period to have a breakage, but reading bminor/glibc@96958e2, the higher value seems okay to me.

@Amanieu
Copy link
Member

Amanieu commented May 31, 2022

This is probably fine, but the constant seems to be informative anyways: the actual limit is a sysctl option that can vary at runtime.

@bors r+

@bors
Copy link
Contributor

bors commented May 31, 2022

📌 Commit cdd7181 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented May 31, 2022

⌛ Testing commit cdd7181 with merge 7ecea9a...

@bors
Copy link
Contributor

bors commented May 31, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 7ecea9a to master...

@bors bors merged commit 7ecea9a into rust-lang:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants