WASI: fix missing Iterator with rustc-dep-of-std#3854
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Aug 19, 2024
Merged
WASI: fix missing Iterator with rustc-dep-of-std#3854tgross35 merged 1 commit intorust-lang:mainfrom
Iterator with rustc-dep-of-std#3854tgross35 merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
Contributor
|
Thanks for the quick fix! I think you can test by temporarily patching this line Line 34 in 5375260 extern crate core as core;. If that doesn't work then I wouldn't worry about testing with that feature. Please make sure wasi still builds locally without that feature, since we don't have it in CI (we should probably add it at some point).
Edit: realizing now that this only tests that the code builds but doesn’t actually verify without the prelude. Still useful, just not 100% accurate. |
Contributor
Author
|
Thank you! I tested both with and without the feature and they look good. It doesn't complain about unused import. |
Contributor
|
Great, thanks! |
Iterator with rustc-dep-of-std
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Aug 19, 2024
(backport <rust-lang#3854>) (cherry picked from commit df33cf9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3681 (comment)
@tgross35 How can I correctly run local test of this build? I tried
cargo build --target wasm32-wasip1 --features rustc-dep-of-std --no-default-featuresbut it causes multiple patch-unrelated errors