Closed
Conversation
Create a module providing the same definitions of `c_char` as in `rust-lang/rust`, which in most cases are based on the architecture rather than the OS. This will allow individual platforms to reexport the definition rather than having configuration repeated in numerous modules.
Collaborator
3 tasks
Contributor
|
The relevant pulls are included in #4206 so I will close this. Fyi I always cherry pick with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports the following to libc-0.2:
c_chartype #4195c_charconfiguration fromrust-lang/rust#41984200 is not actually c_char-related PR, but 4202 depend on import change made in 4200.
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI