adding ethhdr type for linux/android for proper packet filtering.

[devnexen]

No description provided.

[rustbot]

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

Some changes occurred in the Android module

cc @maurer

[maurer]

The main thing I see missing here is a use of ethhdr. A struct type with no usage by libc might not actually belong here, even though it is on the UAPI interface - this is a bindings crate for libc, not for the Linux kernel.

Is there a function in libc that you intend to call that uses the ethhdr struct? If so, layering on a commit binding that on top of this one would make a better PR IMO.

[maurer]

This struct is packed and not align-1.

[devnexen]

I know. was trying to solve few architectures build failures.

[devnexen]

The main thing I see missing here is a use of ethhdr. A struct type with no usage by libc might not actually belong here, even though it is on the UAPI interface - this is a bindings crate for libc, not for the Linux kernel.

There is, for packet filters purpose. sendto/recvfrom can use any buffer e.g. ethhdr for this case. since AF_PACKET family and ETH_P* constants are already there, I m just trying to finish it off.

[tgross35]

Since this is marked as a draft:

@rustbot author

(just update the labels if that isn't accurate)

[devnexen]

@rustbot ready

[tgross35]

Thanks for removing it. LGTM with a squash

[tgross35]

Sorry, guess I didn't see this was ready. Needs a rebase now

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rustbot]

Some changes occurred in an Android module

cc @maurer

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[devnexen]

@rustbot ready