Conversation
Redox changed its signal ABI last year: https://gitlab.redox-os.org/redox-os/relibc/-/commit/63509e75ce127fdb05c07a464e975687e8ef2977 The old definitions (unsurprisingly) cause weird crashes. Use the new ones from Redox's relibc.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
@rustbot author since this is a draft (comment Were you able to figure the tests out? |
|
I am working on actually getting the libc tests compiled for redox and installed into a redox image - once I do I will update the PR and ask rustbot to change the label, but it might take a while as this is very much a spare-time thing. |
|
Fyi it looks like #4426 is making this same change. |
|
Fantastic, let’s go with that change then. They’ve made much better progress with testing too |
Description
Redox changed its signal ABI last year. The old definitions (unsurprisingly) cause weird crashes. Use the new ones from Redox's relibc.
Sources
https://gitlab.redox-os.org/redox-os/relibc/-/commit/63509e75ce127fdb05c07a464e975687e8ef2977
Checklist
I'm still working out how to run tests inside of redox, so I'm leaving this as a draft until I figure that out.
libc-test/semverhave been updated (No update required)*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI